Add handler for typed function signature mismatch #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwhitney
added a commit
to josdejong/mathjs
that referenced
this pull request
Mar 10, 2022
This PR is not intended for merging as-is, but serves as an alternate demonstration (vis-a-vis issue #2437) that essentially all the ingredients already exist in mathjs for evaluation in which all undefined variables evaluate to symbols, therefore possibly returning an expression (Node) rather than a concrete value (while still evaluating all the way to concrete values when possible). Moreover, mathematical manipulation of symbolic expressions can be supported without circularity and without modifying numerous source files. This PR does however depend on a small addition to typed-function.js, see josdejong/typed-function#125. See (or run) examples/symbolic_evaluation.mjs for further details on this.
gwhitney
added a commit
to josdejong/mathjs
that referenced
this pull request
Mar 10, 2022
This PR is not intended for merging as-is, but serves as an alternate demonstration (vis-a-vis issue #2437) that essentially all the ingredients already exist in mathjs for evaluation in which all undefined variables evaluate to symbols, therefore possibly returning an expression (Node) rather than a concrete value (while still evaluating all the way to concrete values when possible). Moreover, mathematical manipulation of symbolic expressions can be supported without circularity and without modifying numerous source files. This PR does however depend on a small addition to typed-function.js, see josdejong/typed-function#125. See (or run) examples/symbolic_evaluation.mjs for further details on this.
|
O wow, such a handler makes a lot of sense! Even if we would not use it in mathjs on short term, it is a useful addition. Can you work out this PR please? (add tests+docs) |
Adds documentation and tests. Exposes the default mismatch handler so that a client can restore the default behavior, and exposes the createError method so that a custom handler can generate the standard message when it might want to.
gwhitney
changed the title
|
Thanks for writing docs and tests Glen, looks very neat 👌 |
|
Published now in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way a client can implement custom behavior in the situation that a typed function call does not match any of its signatures. One specific application is to enable symbolic computation in mathjs (see demo PR to come momentarily).
This is not currently recommended for merging, although if the feature is of interest it's close: it would just need documentation, tests, and likely it would be good to expose
createErroras well for potential use in a client'sonMismatchhandler.