open listbox only if it contains options

[robinboening]

In case the listbox doesn't have any options it doesn't need to be shown.
See this discussion for reference: #178

[robinboening]

@josefarias I wasn't comfortable touching the tests as I am not familiar enough with the setup and all the helpers. Would you mind giving me a hand if you think this should be tested?

[josefarias]

Thanks @robinboening!

I think we can merge this as-is for now. I'm trying to keep the tests mostly functional, and this is arguably presentational.

Might come back and test this later if necessary.

Oh, wasn't expecting any test failures. We should check those out before merging.

[josefarias]

Ah I see what's happening. Prefilled async comboboxes won't work with this change because we need to show the turbo-frame in order to load it lazily.

I'm not able to reproduce this on main anymore though. Am I doing something wrong? I tried with both async and sync comboboxes by making the following changes:

diff --git a/test/dummy/app/controllers/movies_controller.rb b/test/dummy/app/controllers/movies_controller.rb
index 4dd8cdf..924dd38 100644
--- a/test/dummy/app/controllers/movies_controller.rb
+++ b/test/dummy/app/controllers/movies_controller.rb
@@ -15,7 +15,7 @@ class MoviesController < ApplicationController
 
   private
     def set_page
-      movies = params[:full_search] ? Movie.full_search(params[:q]) : Movie.search(params[:q])
+      movies = Movie.none
       set_page_and_extract_portion_from movies.alphabetically, per_page: 5
     end
 end
diff --git a/test/dummy/app/views/comboboxes/plain.html.erb b/test/dummy/app/views/comboboxes/plain.html.erb
index 8a7f5fe..14cce43 100644
--- a/test/dummy/app/views/comboboxes/plain.html.erb
+++ b/test/dummy/app/views/comboboxes/plain.html.erb
@@ -1,3 +1,3 @@
-<%= combobox_tag "state", @state_options, id: "state-field" %>
+<%= combobox_tag "state", [], id: "state-field" %>
 
 <%= button_tag "focusable element" %>

Closing this and the related discussion for now. But happy to reopen if we can get a minimal reproduction on main.