Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop scrolling to top when opening dialog #215

Merged
merged 7 commits into from
Nov 18, 2024
Merged

Conversation

josefarias
Copy link
Owner

@josefarias josefarias commented Oct 14, 2024

closes #186

Also increase top offset to keep page context visible. That makes this a breaking change, as the dialog combobox will look different. It will have more space at the top.

Also increase top offset to keep page context visible
@josefarias josefarias added bug Something isn't working breaking For breaking changes labels Oct 14, 2024
@josefarias josefarias merged commit 23df4bc into main Nov 18, 2024
2 checks passed
@josefarias josefarias deleted the fix-dialog-scroll branch November 18, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking For breaking changes bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant