josefs · erszcz · Jul 14, 2022 · Jul 12, 2022 · Jul 12, 2022 · Jul 12, 2022
diff --git a/.gitignore b/.gitignore
@@ -2,6 +2,7 @@
 deps
 *.o
 *.beam
+*.erltypes
 *.plt
 /.dialyzer_plt
 *~

diff --git a/Makefile b/Makefile
@@ -107,7 +107,7 @@ clean:
 	rm -rf bin/gradualizer ebin cover test/*.beam
 
 .PHONY: tests eunit compile-tests cli-tests
-tests: build_test_data eunit cli-tests
+tests: check_name_clashes build_test_data eunit cli-tests
 
 test_erls=$(wildcard test/*.erl)
 test_beams=$(test_erls:test/%.erl=test/%.beam)
@@ -212,6 +212,14 @@ DIALYZER_OPTS ?= -Werror_handling -Wrace_conditions
 dialyze: app $(DIALYZER_PLT)
 	dialyzer $(DIALYZER_OPTS) ebin
 
+.PHONY: dialyze-tests
+dialyze-tests: app $(DIALYZER_PLT)
+	dialyzer $(DIALYZER_OPTS) $(test_data_erls)
+
 -spec f1() -> boolean(). 
 f1() -> 
   true andalso g1(). 
 -spec g1() -> any(). 
 g1() -> 3. 
 -spec f1() -> boolean(). 
 f1() -> 
   true andalso g1(). 
  
 -spec g1() -> any(). 
 g1() -> 3. 
+.PHONY: check_name_clashes
+check_name_clashes:
+	test/check_name_clashes.sh
+
 # DIALYZER_PLT is a variable understood directly by Dialyzer.
 # Exit status 2 = warnings were emitted
 $(DIALYZER_PLT):

diff --git a/test/check_name_clashes.sh b/test/check_name_clashes.sh
@@ -0,0 +1,26 @@
+#!/usr/bin/env bash
+
+#set -x
+
+if [ x$(uname) == x"Darwin" ]; then
+BASENAME=basename
+else
+BASENAME="basename -a"
+fi
+
+UNIQ=$(find test/should_pass test/should_fail test/known_problems/*/ -name \*.erl \
+        | xargs $BASENAME \
+        | sort \
+        | uniq -c \
+        | sort -n \
+        | tail -1)
+
+COUNT=$(echo $UNIQ | awk '{print $1}')
+
+if [ "$COUNT" == 1 ]; then
+    exit 0
+else
+    echo "Name clash in tests:"
+    find test -name $(echo $UNIQ | awk '{print $2}')
+    exit 1
+fi
diff --git a/...known_problems/should_fail/guard_fail.erl → ...roblems/should_fail/guard_should_fail.erl b/...known_problems/should_fail/guard_fail.erl → ...roblems/should_fail/guard_should_fail.erl
@@ -1,4 +1,4 @@
--module(guard_fail).
+-module(guard_should_fail).
 
 -compile([export_all, nowarn_export_all]).
 

diff --git a/...hould_fail/intersection_with_any_fail.erl → ...ail/intersection_with_any_should_fail.erl b/...hould_fail/intersection_with_any_fail.erl → ...ail/intersection_with_any_should_fail.erl
@@ -1,4 +1,4 @@
--module(intersection_with_any_fail).
+-module(intersection_with_any_should_fail).
 
 -export([any_refined_using_guard/1,
          var_as_pattern/1,

diff --git a/...lems/should_fail/rigid_type_variables.erl → ...should_fail/rigid_type_variables_fail.erl b/...lems/should_fail/rigid_type_variables.erl → ...should_fail/rigid_type_variables_fail.erl
@@ -1,4 +1,4 @@
--module(rigid_type_variables).
+-module(rigid_type_variables_fail).
 
 -compile([export_all, nowarn_export_all]).
 

diff --git a/...lems/should_pass/rigid_type_variables.erl → ...should_pass/rigid_type_variables_pass.erl b/...lems/should_pass/rigid_type_variables.erl → ...should_pass/rigid_type_variables_pass.erl
@@ -1,4 +1,4 @@
--module(rigid_type_variables).
+-module(rigid_type_variables_pass).
 
 -compile([export_all, nowarn_export_all]).
 

diff --git a/test/should_fail/arith_op.erl → test/should_fail/arith_op_fail.erl b/test/should_fail/arith_op.erl → test/should_fail/arith_op_fail.erl
@@ -1,4 +1,5 @@
--module(arith_op).
+-module(arith_op_fail).
+
 -export([failplus/1, faildivvar/1, faildivlit/1, failpositivedivision/1,
          faildivprecise/1, failplusprecise/2, failminusprecisepos/2,
          failminusnonneg/2, failminuspreciseneg/2,

diff --git a/test/should_fail/bc.erl → test/should_fail/bc_fail.erl b/test/should_fail/bc.erl → test/should_fail/bc_fail.erl
@@ -1,4 +1,4 @@
--module(bc).
+-module(bc_fail).
 -export([f/0, non_bin_expr/0, integer_signed_wrong/1]).
 
 -spec f() -> binary().

diff --git a/test/should_fail/catch_expr.erl → test/should_fail/catch_expr_fail.erl b/test/should_fail/catch_expr.erl → test/should_fail/catch_expr_fail.erl
@@ -1,4 +1,4 @@
--module(catch_expr).
+-module(catch_expr_fail).
 
 -export([foo/1]).
 

diff --git a/test/should_fail/covariant_map_keys.erl → test/should_fail/covariant_map_keys_fail.erl b/test/should_fail/covariant_map_keys.erl → test/should_fail/covariant_map_keys_fail.erl
@@ -1,4 +1,4 @@
--module(covariant_map_keys).
+-module(covariant_map_keys_fail).
 
 -compile([nowarn_unused_function]).
 -export([not_good/1]).

diff --git a/test/should_fail/intersection_with_any.erl → ...hould_fail/intersection_with_any_fail.erl b/test/should_fail/intersection_with_any.erl → ...hould_fail/intersection_with_any_fail.erl
@@ -1,4 +1,4 @@
--module(intersection_with_any).
+-module(intersection_with_any_fail).
 
 -export([intersection_using_constraints/1]).
 

diff --git a/test/should_fail/list_infer.erl → test/should_fail/list_infer_fail.erl b/test/should_fail/list_infer.erl → test/should_fail/list_infer_fail.erl
@@ -1,4 +1,4 @@
--module(list_infer).
+-module(list_infer_fail).
 
 -gradualizer(infer).
 -export([f/0]).

diff --git a/test/should_fail/messaging.erl → test/should_fail/messaging_fail.erl b/test/should_fail/messaging.erl → test/should_fail/messaging_fail.erl
@@ -1,4 +1,4 @@
--module(messaging).
+-module(messaging_fail).
 
 -export([server1/0, server2/0, server3/0, server4/0]).
 

diff --git a/test/should_fail/named_fun.erl → test/should_fail/named_fun_fail.erl b/test/should_fail/named_fun.erl → test/should_fail/named_fun_fail.erl
@@ -1,4 +1,4 @@
--module(named_fun).
+-module(named_fun_fail).
 
 -export([bar/0, baz/1]).
 

diff --git a/test/should_fail/named_fun_infer.erl → test/should_fail/named_fun_infer_fail.erl b/test/should_fail/named_fun_infer.erl → test/should_fail/named_fun_infer_fail.erl
@@ -1,4 +1,4 @@
--module(named_fun_infer).
+-module(named_fun_infer_fail).
 
 -gradualizer(infer).
 -export([bar/0, sum/1]).

diff --git a/test/should_fail/operator_pattern.erl → test/should_fail/operator_pattern_fail.erl b/test/should_fail/operator_pattern.erl → test/should_fail/operator_pattern_fail.erl
@@ -1,4 +1,4 @@
--module(operator_pattern).
+-module(operator_pattern_fail).
 -export([n/1, p/1]).
 
 -spec n(non_neg_integer()) -> {}.

diff --git a/test/should_fail/record_refinement_fail.erl b/test/should_fail/record_refinement_fail.erl
@@ -16,6 +16,8 @@ one_field2(_, I) -> I.
 -spec refined_field(#refined_field{}) -> #refined_field{f :: integer()}.
 refined_field(R) -> R.
 
+%% The refinement in the result type is not handled by Dialyzer - it will error out.
+%% Comment it out if trying to run `make dialyze-tests'.
 -spec refined_field2(#refined_field{}) -> #refined_field{f :: atom()}.
 refined_field2(#refined_field{f = undefined}) -> #refined_field{f = 0};
 refined_field2(R) -> R.

diff --git a/test/should_fail/record_wildcard.erl → test/should_fail/record_wildcard_fail.erl b/test/should_fail/record_wildcard.erl → test/should_fail/record_wildcard_fail.erl
@@ -1,4 +1,4 @@
--module(record_wildcard).
+-module(record_wildcard_fail).
 
 -export([f/0, g/0]).
 

diff --git a/test/should_fail/send.erl → test/should_fail/send_fail.erl b/test/should_fail/send.erl → test/should_fail/send_fail.erl
@@ -1,4 +1,4 @@
--module(send).
+-module(send_fail).
 
 -export([foo/2, bar/2]).
 

diff --git a/test/should_fail/shortcut_ops.erl → test/should_fail/shortcut_ops_fail.erl b/test/should_fail/shortcut_ops.erl → test/should_fail/shortcut_ops_fail.erl
@@ -1,4 +1,4 @@
--module(shortcut_ops).
+-module(shortcut_ops_fail).
 
 -compile([export_all, nowarn_export_all]).
 

diff --git a/test/should_fail/tuple_union.erl b/test/should_fail/tuple_union.erl
diff --git a/test/should_fail/tuple_union_fail.erl b/test/should_fail/tuple_union_fail.erl
@@ -1,7 +1,12 @@
 -module(tuple_union_fail).
 
 -export([f/0]).
+-export([tuple_union/0]).
 
 -spec f() -> {integer()} | {boolean()}.
 f() ->
     {apa}.
+
+-spec tuple_union() -> {undefined, binary()} | {integer(), undefined}.
+tuple_union() ->
+    {undefined, undefined}.
diff --git a/test/should_fail/type_refinement.erl → test/should_fail/type_refinement_fail.erl b/test/should_fail/type_refinement.erl → test/should_fail/type_refinement_fail.erl
@@ -1,4 +1,4 @@
--module(type_refinement).
+-module(type_refinement_fail).
 -export([guard_prevents_refinement/2, imprecision_prevents_refinement/2,
          multi_pat_fail_1/2,
          guard_prevents_refinement2/1,

diff --git a/test/should_pass/bc.erl → test/should_pass/bc_pass.erl b/test/should_pass/bc.erl → test/should_pass/bc_pass.erl
@@ -1,4 +1,4 @@
--module(bc).
+-module(bc_pass).
 
 -compile([export_all, nowarn_export_all]).
 

diff --git a/test/should_pass/catch_expr.erl → test/should_pass/catch_expr_pass.erl b/test/should_pass/catch_expr.erl → test/should_pass/catch_expr_pass.erl
@@ -1,4 +1,4 @@
--module(catch_expr).
+-module(catch_expr_pass).
 
 -export([foo/1]).
 

diff --git a/test/should_pass/covariant_map_keys.erl → test/should_pass/covariant_map_keys_pass.erl b/test/should_pass/covariant_map_keys.erl → test/should_pass/covariant_map_keys_pass.erl
@@ -1,4 +1,4 @@
--module(covariant_map_keys).
+-module(covariant_map_keys_pass).
 
 -compile([export_all, nowarn_export_all]).
 

diff --git a/test/should_pass/intersection.erl → test/should_pass/intersection_pass.erl b/test/should_pass/intersection.erl → test/should_pass/intersection_pass.erl
@@ -1,4 +1,4 @@
--module(intersection).
+-module(intersection_pass).
 
 -compile([export_all, nowarn_export_all]).
 

diff --git a/test/should_pass/intersection_with_any.erl → ...hould_pass/intersection_with_any_pass.erl b/test/should_pass/intersection_with_any.erl → ...hould_pass/intersection_with_any_pass.erl
@@ -1,4 +1,4 @@
--module(intersection_with_any).
+-module(intersection_with_any_pass).
 
 -compile([export_all, nowarn_export_all]).
 

diff --git a/test/should_pass/list_infer.erl → test/should_pass/list_infer_pass.erl b/test/should_pass/list_infer.erl → test/should_pass/list_infer_pass.erl
@@ -1,4 +1,4 @@
--module(list_infer).
+-module(list_infer_pass).
 
 -gradualizer(infer).
 -export([f/0]).

diff --git a/test/should_pass/messaging.erl → test/should_pass/messaging_pass.erl b/test/should_pass/messaging.erl → test/should_pass/messaging_pass.erl
@@ -1,4 +1,4 @@
--module(messaging).
+-module(messaging_pass).
 
 -export([main/0, server/0, server1/0, server2/0, server3/0, server4/0]).
 

diff --git a/test/should_pass/named_fun_infer.erl → test/should_pass/named_fun_infer_pass.erl b/test/should_pass/named_fun_infer.erl → test/should_pass/named_fun_infer_pass.erl
@@ -1,4 +1,4 @@
--module(named_fun_infer).
+-module(named_fun_infer_pass).
 
 -gradualizer(infer).
 -export([atom_sum/1]).

diff --git a/test/should_pass/named_fun.erl → test/should_pass/named_fun_pass.erl b/test/should_pass/named_fun.erl → test/should_pass/named_fun_pass.erl
@@ -1,4 +1,4 @@
--module(named_fun).
+-module(named_fun_pass).
 
 -export([fac/1, sum/1]).
 

diff --git a/test/should_pass/operator_pattern.erl → test/should_pass/operator_pattern_pass.erl b/test/should_pass/operator_pattern.erl → test/should_pass/operator_pattern_pass.erl
@@ -1,4 +1,4 @@
--module(operator_pattern).
+-module(operator_pattern_pass).
 
 -compile([export_all, nowarn_export_all]).
 

diff --git a/test/should_pass/record_wildcard.erl → test/should_pass/record_wildcard_pass.erl b/test/should_pass/record_wildcard.erl → test/should_pass/record_wildcard_pass.erl
@@ -1,4 +1,4 @@
--module(record_wildcard).
+-module(record_wildcard_pass).
 
 -export([f/0, g/0, h/1]).
 

diff --git a/test/should_pass/records.erl b/test/should_pass/records.erl
@@ -1,9 +1,10 @@
 -module(records).
 
--export([f/0, g/1, h/0, i/0, j/0, k/0, l/0,
+-export([f/0, f/1, g/1, h/0, i/0, j/0, k/0, l/0,
          rec_field_subtype/1,
          rec_index_subtype/0,
-         record_as_tuple/1]).
+         record_as_tuple/1,
+         nospec_update_bug/1]).
 
 -record(r, {f1     :: atom(),
             f2 = 1 :: integer()}).

diff --git a/test/should_pass/send.erl → test/should_pass/send_pass.erl b/test/should_pass/send.erl → test/should_pass/send_pass.erl
@@ -1,4 +1,4 @@
--module(send).
+-module(send_pass).
 
 -export([foo/2, bar/2]).
 

diff --git a/test/should_pass/shortcut_ops.erl → test/should_pass/shortcut_ops_pass.erl b/test/should_pass/shortcut_ops.erl → test/should_pass/shortcut_ops_pass.erl
@@ -1,4 +1,4 @@
--module(shortcut_ops).
+-module(shortcut_ops_pass).
 
 -compile([export_all, nowarn_export_all]).
 

diff --git a/test/should_pass/tuple_union.erl → test/should_pass/tuple_union_pass.erl b/test/should_pass/tuple_union.erl → test/should_pass/tuple_union_pass.erl
@@ -1,4 +1,4 @@
--module(tuple_union).
+-module(tuple_union_pass).
 
 -export([f/0]).
 

diff --git a/test/should_pass/type_refinement.erl → test/should_pass/type_refinement_pass.erl b/test/should_pass/type_refinement.erl → test/should_pass/type_refinement_pass.erl
@@ -1,4 +1,4 @@
--module(type_refinement).
+-module(type_refinement_pass).
 
 -compile([export_all, nowarn_export_all]).