-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
viewport meta tag doesn't reflect current best use for iOS #198
Comments
thanks! |
Hey gentlemen, I'm not sure that |
I did not expect that change to just be merged TBH. I'd rather start a discussion and find out what a good default is. Adding it to the documentation of what can be done and what it is for might be the better solution. |
yup. i jumped the gun here by not providing reasoning why i merged the change. Upon review / testing on iOS devices running v10.3, v11.x and 12.1 I'll be posting a write up about this soon. |
Report: https://www.scottohara.me/blog/2018/12/11/shrink-to-fit.html which contains more testing of earlier iOS versions. tldr; |
Apologies for the late response, open source has been low on my list of priorities lately. Excellent writeup @scottaohara 👌 I'm on-board, let's remove |
Also — FWIW @e110c0 I think we definitely should include |
no worries @joshbuchea :) |
@scottaohara I'm not sure how large this dataset is but, iOS 9.0-9.2.x usage is currently only @ 0.17% https://data.apteligent.com/ios/ |
oh that's interesting. thank you @joshbuchea. going to update my article with that link. Coupled with the one I already had in the article, more data points the better. :) |
Oh yeah and almost forgot — @scottaohara thank you for doing that research and for publishing your findings 💯 |
i like to share :) |
@scottaohara totally agree it's not a recommended minimum. Having all possible options in the documentation would be nice. I still haven't figured out all pitfalls of it, so not comfortable with creating a PR at the moment |
It doesn't reflect current best use for iOS anymore. See joshbuchea/HEAD#198 and https://www.scottohara.me/blog/2018/12/11/shrink-to-fit.html.
It doesn't reflect current best use for iOS anymore. See joshbuchea/HEAD#198 and https://www.scottohara.me/blog/2018/12/11/shrink-to-fit.html.
with the iPhone X being over a year old and the iPad now having safe areas as well, changing the default viewport tag to something like
'initial-scale=1, viewport-fit=cover'
would be more appropriate.The text was updated successfully, but these errors were encountered: