feat: atomsWithQueryAsync, plus example

[leweyse]

Fix to #21

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9bb7892:

Sandbox	Source
React	Configuration
React Typescript	Configuration

[dai-shi]

Thanks for working on it. Can you please try adding some tests? You don't need to follow the patterns of existing tests.

[dai-shi]

With pmndrs/jotai#1741, we should be able to use it.

Suggested change

	import type { ExtractAtomValue, Getter, WritableAtom } from 'jotai'
	import type { ExtractAtomArgs, ExtractAtomValue, Getter, WritableAtom } from 'jotai'

[leweyse]

Hi @dai-shi , I have a couple of doubts.

First, I tried to add a test for the refetch functionality for the new async atom (async query refetch test), but I have some problems trying to set this up. Do you have any comments on that test? Any ideas on how can we approach it?

Second, when we fire the dispatch setter from the atomsWithQueryAsync, and we pass the force argument as true, the component is suspended forever. You can find the code here: https://codesandbox.io/s/hopeful-silence-f2zs2k?file=/src/App.tsx

[dai-shi]

First, I tried to add a test for the refetch functionality for the new async atom (async query refetch test), but I have some problems trying to set this up. Do you have any comments on that test? Any ideas on how can we approach it?

Not sure. Is it only about tests? It works in codesandbox, right?

Second, when we fire the dispatch setter from the atomsWithQueryAsync, and we pass the force argument as true, the component is suspended forever. You can find the code here: https://codesandbox.io/s/hopeful-silence-f2zs2k?file=/src/App.tsx

Oh, I didn't realized that. Does it work with atomsWithQuery? Not sure if we can fix it. Maybe for now we reject using force in atomsWithQueryAsync?

[leweyse]

I was able to fix the tests, and force has no effect on the query at this moment.

First, I tried to add a test for the refetch functionality for the new async atom (async query refetch test), but I have some problems trying to set this up. Do you have any comments on that test? Any ideas on how can we approach it?

Not sure. Is it only about tests? It works in codesandbox, right?

Second, when we fire the dispatch setter from the atomsWithQueryAsync, and we pass the force argument as true, the component is suspended forever. You can find the code here: https://codesandbox.io/s/hopeful-silence-f2zs2k?file=/src/App.tsx

Oh, I didn't realized that. Does it work with atomsWithQuery? Not sure if we can fix it. Maybe for now we reject using force in atomsWithQueryAsync?

[dai-shi]

I was able to fix the tests

Nice.

and force has no effect on the query at this moment.

Fine. Do you want to disable the force option in atomsWithQueryAsync?

Please check CI results. Seems like trivial linting issue.

[leweyse]

I'd rather not to disable it, so I worked on a fix. I updated the sandbox: https://codesandbox.io/s/hopeful-silence-f2zs2k?file=/src/App.tsx