Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note and warning text block colors are semantically misleading #123

Closed
dsieger opened this issue Jul 17, 2023 · 3 comments
Closed

Note and warning text block colors are semantically misleading #123

dsieger opened this issue Jul 17, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@dsieger
Copy link

dsieger commented Jul 17, 2023

Ok now this is about details, but: I think the colors for the "Note" and "Warning" text boxes produced by the \note and \warning commands are semantically misleading.

Notes use orange, but in most other systems this defaults to some more neutral color like blue (like your "Todo" boxes). After all, a note is just that: something noteworthy. I want the reader to take note, but I don't want to alert him. No danger, no harm.

Similar, the "Warning" boxes probably should use orange to signify potential danger, whereas red should be reserved for something definitely bad, like bugs.

Just my 2 cents, feel free to close immediately.

@jothepro jothepro added the enhancement New feature or request label Jul 17, 2023
@jothepro
Copy link
Owner

Tbh not a lot of thought has been going into the current coloring, so your 2 cents are welcome! 😋 Keeping this open a reminder that the colors could be improved.

@ilg-ul
Copy link
Contributor

ilg-ul commented Jul 17, 2023

I also find the choice of colours unusual, even misleading. The other sites that I manage use a colour convention similar to the one suggested by @dsieger.

dsieger added a commit to pmp-library/pmp-library that referenced this issue Aug 20, 2023
@jothepro
Copy link
Owner

I've applied the color scheme from pmp-library/pmp-library@54e8e75 and I like it a lot more than the previous coloring! It's now available in v2.3.0. Thanks for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants