-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Abstract storage backend #205
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cannium
requested review from
thesues,
cxt90730,
dahefanteng and
chenji-kael
September 27, 2019 11:23
cxt90730
reviewed
Sep 29, 2019
cannium
force-pushed
the
backend-interface
branch
3 times, most recently
from
September 30, 2019 08:14
b1bb08d
to
f3d663b
Compare
chenji-kael
reviewed
Oct 8, 2019
chenji-kael
approved these changes
Oct 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
resolve conflicts first... |
for unit tests and new backends
cannium
force-pushed
the
backend-interface
branch
from
October 9, 2019 01:53
a84cf67
to
2f443ce
Compare
cannium
force-pushed
the
backend-interface
branch
2 times, most recently
from
October 9, 2019 03:19
fe517b2
to
1fae61b
Compare
cannium
force-pushed
the
backend-interface
branch
from
October 9, 2019 03:29
1fae61b
to
b4c0c80
Compare
cxt90730
approved these changes
Oct 9, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an interface storage
Cluster
, for unit tests and new backends. Code is modified from part of #194