Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance fields conversion logic to support custom converters #191

Merged
merged 18 commits into from
May 21, 2023
Merged

Conversation

jowilf
Copy link
Owner

@jowilf jowilf commented May 20, 2023

No description provided.

@github-actions
Copy link

github-actions bot commented May 20, 2023

@github-actions github-actions bot temporarily deployed to pull request May 20, 2023 21:44 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 20, 2023 22:41 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 20, 2023 22:47 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 20, 2023 22:54 Inactive
@codecov
Copy link

codecov bot commented May 20, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (f9237b5) 100.00% compared to head (6a4d18d) 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##              main      #191    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           64        68     +4     
  Lines         4713      4920   +207     
==========================================
+ Hits          4713      4920   +207     
Impacted Files Coverage Δ
starlette_admin/contrib/mongoengine/helpers.py 100.00% <ø> (ø)
starlette_admin/contrib/odmantic/helpers.py 100.00% <ø> (ø)
starlette_admin/contrib/sqla/__init__.py 100.00% <ø> (ø)
starlette_admin/contrib/sqla/helpers.py 100.00% <ø> (ø)
starlette_admin/fields.py 100.00% <ø> (ø)
starlette_admin/contrib/mongoengine/converters.py 100.00% <100.00%> (ø)
starlette_admin/contrib/mongoengine/view.py 100.00% <100.00%> (ø)
starlette_admin/contrib/odmantic/converters.py 100.00% <100.00%> (ø)
starlette_admin/contrib/odmantic/view.py 100.00% <100.00%> (ø)
starlette_admin/contrib/sqla/converters.py 100.00% <100.00%> (ø)
... and 6 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions github-actions bot temporarily deployed to pull request May 20, 2023 23:18 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 21, 2023 00:12 Inactive
@jowilf jowilf merged commit b4a9e64 into main May 21, 2023
This was referenced May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant