Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support favicon customization #520

Merged
merged 7 commits into from
Mar 14, 2024
Merged

Support favicon customization #520

merged 7 commits into from
Mar 14, 2024

Conversation

omarmoo5
Copy link
Contributor

@omarmoo5 omarmoo5 commented Mar 4, 2024

Solves #519 .

disrupted
disrupted reviewed Mar 4, 2024
View reviewed changes
Copy link
Contributor

@disrupted disrupted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing to see this being picked up so quickly 🎉

starlette_admin/templates/base.html Outdated Show resolved Hide resolved
@omarmoo5
Copy link
Contributor Author

omarmoo5 commented Mar 4, 2024

amazing to see this being picked up so quickly 🎉

I had this thoughts in one of my projects recently. your issue inspired me to open this PR.

disrupted
disrupted reviewed Mar 4, 2024
View reviewed changes
Copy link
Contributor

@disrupted disrupted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the Admin class also needs to be updated to include the new keyword argument

@omarmoo5 omarmoo5 marked this pull request as draft March 4, 2024 15:48
@omarmoo5 omarmoo5 marked this pull request as ready for review March 4, 2024 19:48
disrupted
disrupted approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@disrupted disrupted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tested this and it works great, thanks!

@jowilf
Copy link
Owner

jowilf commented Mar 6, 2024

Thank @omarmoo5 for this PR and thanks @disrupted for your reviews
@omarmoo5 You forgot the mongoengine Admin class

@codecov Codecov
Copy link

codecov bot commented Mar 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2540c51) to head (5095b44).
Report is 8 commits behind head on main.

❗ Current head 5095b44 differs from pull request most recent head a849565. Consider uploading reports for the commit a849565 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #520   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           75        75           
  Lines         5817      5819    +2     
=========================================
+ Hits          5817      5819    +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jowilf
jowilf requested changes Mar 6, 2024
View reviewed changes
Copy link
Owner

@jowilf jowilf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@omarmoo5
Copy link
Contributor Author

omarmoo5 commented Mar 7, 2024

@omarmoo5 You forgot the mongoengine Admin class

@jowilf mongoengine Admin class doesn't implement it's own constructor, i believe no modification is required there. right ?

@omarmoo5 omarmoo5 requested a review from jowilf March 7, 2024 14:29
@jowilf
Copy link
Owner

jowilf commented Mar 13, 2024

@jowilf mongoengine Admin class doesn't implement it's own constructor, i believe no modification is required there. right ?

You are absolutely right! I didn't double-check and relied on my memory 😅

jowilf
jowilf approved these changes Mar 13, 2024
View reviewed changes
Copy link
Owner

@jowilf jowilf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Can you update the Unreleased section in doc/changelog, so I can merge it directly?

@omarmoo5
Copy link
Contributor Author

This looks good to me. Can you update the Unreleased section in doc/changelog, so I can merge it directly?

Thanks, Done.

@jowilf jowilf merged commit 55f1ecf into jowilf:main Mar 14, 2024
7 checks passed
@jowilf
Copy link
Owner

jowilf commented Mar 14, 2024

Thank you @omarmoo5 for your contribution

@jowilf jowilf mentioned this pull request May 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jowilf jowilf jowilf approved these changes

@disrupted disrupted disrupted approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@omarmoo5 @jowilf @disrupted