Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crash in ida8.3 #288

Closed
zh913457894 opened this issue Nov 30, 2023 · 2 comments
Closed

crash in ida8.3 #288

zh913457894 opened this issue Nov 30, 2023 · 2 comments
Assignees

Comments

@zh913457894
Copy link

zh913457894 commented Nov 30, 2023

I use diaphora under ida8.3.
diaphora version 3.1.1.
I want to export ida database to sqlite, settings are all default options,only the 'to address' option has been modified.
I tried it twice and got the same crash

The crash log is as follows:

Traceback (most recent call last):
  File "D:/gihub/diaphora-master-3.11/diaphora-master\diaphora_ida.py", line 1250, in export
    self.do_export(crashed_before)
  File "D:/gihub/diaphora-master-3.11/diaphora-master\diaphora_ida.py", line 1195, in do_export
    props = self.read_function(func)
  File "D:/gihub/diaphora-master-3.11/diaphora-master\diaphora_ida.py", line 2989, in read_function
    asm, assembly_addrs = self.extract_function_assembly_features(
  File "D:/gihub/diaphora-master-3.11/diaphora-master\diaphora_ida.py", line 2615, in extract_function_assembly_features
    keys.remove(base)
ValueError: list.remove(x): x not in list
[Diaphora: Thu Nov 30 10:14:42 2023] Removing crash file D:\img\XXXXXN002.2244B\sox.bin.sqlite-crash....
@joxeankoret joxeankoret self-assigned this Dec 4, 2023
@joxeankoret
Copy link
Owner

This is the first time I see this bug. Can you please share a sample reproducing this? Because reading the source... I cannot figure out at all why is it failing.

joxeankoret added a commit that referenced this issue Dec 22, 2023
BUG: For some reason, the function `extract_function_assembly_features()` might receive a list of basic blocks not containing the function's entry point and Diaphora didn't consider this possibility.

This is a bug I cannot reproduce at all but that, I think, can be easily fixed.
@joxeankoret
Copy link
Owner

I believe I have fixed it. Feel free to reopen if you hit it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants