Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not continue when enough contributions have been received #79

Merged
merged 1 commit into from
Nov 27, 2014

Conversation

sigmike
Copy link
Contributor

@sigmike sigmike commented Nov 23, 2014

When a limited number of contributions is requested, Mediawiki now sends a reply with the continue attributes, so the gateway keeps requesting contributions.

Now it stops when the count is reached.

@blackwinter
Copy link
Collaborator

Thanks for your report. I'll look into it when time allows.

blackwinter added a commit to blackwinter/mediawiki-gateway that referenced this pull request Nov 27, 2014
Do not continue when enough contributions have been received
blackwinter added a commit to blackwinter/mediawiki-gateway that referenced this pull request Nov 27, 2014
@blackwinter blackwinter merged commit 5880b01 into jpatokal:master Nov 27, 2014
@blackwinter
Copy link
Collaborator

I've merged your patch. Thank you for your contribution! Please let me know if you need this change in a published release right away.

For lack of test cases and/or suitable examples, I have not verified the behaviour myself beyond inspecting the code. I trust that it works the way you intended it to and doesn't break any existing functionality. (I guess, however, that result.take(count) is redundant now.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants