Change the exception superclass to StandardError #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the superclass of MediaWiki::Exception from ::Exception to ::StandardError. It's best practice in Ruby to rescue StandardError instead of Exception. Exceptions that are not StandardErrors are reserved for things like Interrupts, out of memory errors, and so on. Normal Ruby code is supposed to use StandardErrors.
jpatokal
added a commit
that referenced
this pull request
Apr 29, 2015
Change the exception superclass to StandardError
|
Merged, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the superclass of MediaWiki::Exception from ::Exception to ::StandardError.
It's best practice in Ruby to rescue StandardError instead of Exception. Exceptions that are not StandardErrors are reserved for things like Interrupts, out of memory errors, and so on. Normal Ruby code is supposed to use StandardErrors.