Swap sortKeys bool for keySort function
#315
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Could you please rebase your commits on top of |
kevboh
force-pushed
the
feat-add-sort-key-function
branch
from
19933d7 to
8c97204
Compare
|
@jpsim this has been rebased. Thanks for taking a look! |
|
@jpsim let me know if anything else is required here. |
|
Hi, is this still mergeable? If so I'd love to merge it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This is a breaking change, but I can make it non-breaking if preferred. It's just a lot more code repetition if non-breaking.)
This changes the
sortKeysoption to be a more flexiblekeySortfunction. The function defaults tonil—do not sort—but can be anything that sortsNodes. I ran into an issue where I wanted a custom sort on a mapping.