fix option parsing of --binary on non-Windows platforms
#3131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`-b`/`--binary` should be accepted on all platforms so that they can be used in code that is meant to be portable. Signed-off-by: Christoph Anton Mitterer <[email protected]>
|
Hey, thanks! look good to me. I wonder if we should add a regression test for this in |
|
For this particular case I, personally, would rather it's not worth a test. The test would only tell when the option parsing itself fails again, which I guess is unlikely, but even if, it would be something that's quickly noticed. I'd rather like to see tests that check whether the different combinations of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-b/--binaryshould be accepted on all platforms so that they can be used in code that is meant to be portable.