Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit unnecessary matrix variables in the CI workflow #3207

Closed
wants to merge 1 commit into from

Conversation

itchyny
Copy link
Contributor

@itchyny itchyny commented Nov 20, 2024

@itchyny
Copy link
Contributor Author

itchyny commented Nov 20, 2024

Ah, this change requires the branch protection rule to be changed, and existing PRs need to be rebased after merging 😢

@itchyny itchyny closed this Nov 26, 2024
@itchyny itchyny deleted the simplify-ci-workflow-matrix branch November 26, 2024 06:36
@wader
Copy link
Member

wader commented Nov 26, 2024

@itchyny not sure i followed how this was connected to branch protection rules? is it about that github actions is not smart enough to see that it won't change what jobs to run etc?

@itchyny
Copy link
Contributor Author

itchyny commented Nov 26, 2024

@wader
The required status checks are configured by the check names, and they are generated by the matrix variables. Now it is configured as linux (amd64) is required, but the status checks reported by this PR was linux (amd64, x86_64-linux-gnu). Probably if the check names are generated by the include configurations if the matrix variables do not exist. We can't configure OR condition for the required status checks (if possible, it would be great), so possible solution (not to force others rebase their PRs) is to remove the requirements for while and then re-configure the check requirements.

@wader
Copy link
Member

wader commented Nov 26, 2024

Aha i see, that is messy hmm, thanks for explaining

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants