-
Notifications
You must be signed in to change notification settings - Fork 75
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #461 from janeisklar/lombok-support-cached-hashcode
#460: Add support for @EqualsAndHashCode(cacheStrategy = LAZY)
- Loading branch information
Showing
4 changed files
with
190 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
127 changes: 127 additions & 0 deletions
127
...va/nl/jqno/equalsverifier/integration/extra_features/LombokLazyEqualsAndHashcodeTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,127 @@ | ||
| package nl.jqno.equalsverifier.integration.extra_features; | ||
|
|
||
| import static org.hamcrest.MatcherAssert.assertThat; | ||
| import static org.hamcrest.core.StringContains.containsString; | ||
| import static org.junit.jupiter.api.Assertions.assertThrows; | ||
|
|
||
| import nl.jqno.equalsverifier.EqualsVerifier; | ||
| import nl.jqno.equalsverifier.Warning; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| // CHECKSTYLE OFF: LocalFinalVariableName | ||
| // CHECKSTYLE OFF: MemberName | ||
| // CHECKSTYLE OFF: NeedBraces | ||
|
|
||
| public class LombokLazyEqualsAndHashcodeTest { | ||
|
|
||
| @Test | ||
| void testWithLombokCachedHashCode() { | ||
| EqualsVerifier | ||
| .forClass(LazyPojo.class) | ||
| .withLombokCachedHashCode(new LazyPojo("a", new Object())) | ||
| .suppress(Warning.STRICT_INHERITANCE) | ||
| .verify(); | ||
| } | ||
|
|
||
| @Test | ||
| void testDefaultEqualsVerifierFailsForCachedLombokEqualsAndHashcode() { | ||
| final AssertionError error = assertThrows( | ||
| AssertionError.class, | ||
| () -> | ||
| EqualsVerifier | ||
| .forClass(LazyPojo.class) | ||
| .suppress(Warning.STRICT_INHERITANCE) | ||
| .verify() | ||
| ); | ||
| assertThat( | ||
| error.getMessage(), | ||
| containsString("hashCode relies on $hashCodeCache, but equals does not.") | ||
| ); | ||
| } | ||
|
|
||
| @Test | ||
| void testDefaultEqualsVerifierFailsForCachedLombokEqualsAndHashcodeWhenUsingWithCachedHashCode() { | ||
| final IllegalArgumentException error = assertThrows( | ||
| IllegalArgumentException.class, | ||
| () -> | ||
| EqualsVerifier | ||
| .forClass(LazyPojo.class) | ||
| .suppress(Warning.STRICT_INHERITANCE) | ||
| .withCachedHashCode( | ||
| "$hashCodeCache", | ||
| "hashCode", | ||
| new LazyPojo("bar", new Object()) | ||
| ) | ||
| .verify() | ||
| ); | ||
| assertThat( | ||
| error.getMessage(), | ||
| containsString( | ||
| "Cached hashCode: Could not find calculateHashCodeMethod: must be 'private int hashCode()'" | ||
| ) | ||
| ); | ||
| } | ||
|
|
||
| /** | ||
| * This class has been generated with Lombok (1.18.20). It is equivalent to: | ||
| * <pre> | ||
| * @RequiredArgsConstructor | ||
| * @EqualsAndHashCode(cacheStrategy = EqualsAndHashCode.CacheStrategy.LAZY) | ||
| * public class LazyPojo { | ||
| * | ||
| * private final String foo; | ||
| * | ||
| * private final Object bar; | ||
| * } | ||
| * </pre> | ||
| */ | ||
| @SuppressWarnings({ "RedundantIfStatement", "EqualsReplaceableByObjectsCall" }) | ||
| private static class LazyPojo { | ||
|
|
||
| private transient int $hashCodeCache; | ||
|
|
||
| private final String foo; | ||
| private final Object bar; | ||
|
|
||
| public LazyPojo(String foo, Object bar) { | ||
| this.foo = foo; | ||
| this.bar = bar; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean equals(final Object o) { | ||
| if (o == this) return true; | ||
| if (!(o instanceof LazyPojo)) return false; | ||
| final LazyPojo other = (LazyPojo) o; | ||
| if (!other.canEqual(this)) return false; | ||
| final Object this$foo = this.foo; | ||
| final Object other$foo = other.foo; | ||
| if (this$foo == null ? other$foo != null : !this$foo.equals(other$foo)) return false; | ||
| final Object this$bar = this.bar; | ||
| final Object other$bar = other.bar; | ||
| if (this$bar == null ? other$bar != null : !this$bar.equals(other$bar)) return false; | ||
| return true; | ||
| } | ||
|
|
||
| protected boolean canEqual(Object other) { | ||
| return other instanceof LazyPojo; | ||
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { | ||
| if (this.$hashCodeCache != 0) { | ||
| return this.$hashCodeCache; | ||
| } else { | ||
| final int PRIME = 59; | ||
| int result = 1; | ||
| final Object $foo = this.foo; | ||
| result = result * PRIME + ($foo == null ? 43 : $foo.hashCode()); | ||
| final Object $bar = this.bar; | ||
| result = result * PRIME + ($bar == null ? 43 : $bar.hashCode()); | ||
|
|
||
| this.$hashCodeCache = result; | ||
| return result; | ||
| } | ||
| } | ||
| } | ||
| } |