Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance. Test works too long #190

Closed
turbanoff opened this issue Apr 16, 2018 · 1 comment
Closed

Performance. Test works too long #190

turbanoff opened this issue Apr 16, 2018 · 1 comment
Labels

Comments

@turbanoff
Copy link
Contributor

turbanoff commented Apr 16, 2018

What steps will reproduce the problem?

I have unit test which check equality for one class.
This test run for a long time. I checked - it's due to repeating non-null checking for same type
default

AccountActionCriteria class has 34 fields.
I checked count of packageHasAnnotation calls from single test. Its 7158.

7151. Check package for AccountActionCriteria has annotation JSR305_DEFAULT_ANNOTATION_NONNULL
7152. Check package for AccountActionCriteria has annotation ECLIPSE_DEFAULT_ANNOTATION_NONNULL
7153. Check package for AccountActionCriteria has annotation FINDBUGS1X_DEFAULT_ANNOTATION_NONNULL
7154. Check package for AccountActionCriteria has annotation JSR305_DEFAULT_ANNOTATION_NONNULL
7155. Check package for AccountActionCriteria has annotation ECLIPSE_DEFAULT_ANNOTATION_NONNULL
7156. Check package for AccountActionCriteria has annotation FINDBUGS1X_DEFAULT_ANNOTATION_NONNULL
7157. Check package for AccountActionCriteria has annotation JSR305_DEFAULT_ANNOTATION_NONNULL
7158. Check package for AccountActionCriteria has annotation ECLIPSE_DEFAULT_ANNOTATION_NONNULL

What did you expect?

Faster test execution time. Can annotation info be cached?

Which version of EqualsVerifier are you using?

2.4.5

@jqno
Copy link
Owner

jqno commented Apr 17, 2018

Thanks for reporting this. I knew that part of the code wasn't optimal, but I didn't know it was this bad. I'll look into it.

@jqno jqno added the accepted label Apr 24, 2018
@jqno jqno closed this as completed in 7a7ee29 Jun 20, 2018
akhalikov pushed a commit to akhalikov/equalsverifier that referenced this issue Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants