Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make implementing a new pyborg module simpler #93

Open
jrabbit opened this issue Apr 27, 2019 · 1 comment
Open

Make implementing a new pyborg module simpler #93

jrabbit opened this issue Apr 27, 2019 · 1 comment
Assignees
Milestone

Comments

@jrabbit
Copy link
Owner

jrabbit commented Apr 27, 2019

We should make the commands registry pattern eas(ier) to copy into new modules.
We could provide learn/reply methods via a baseclass with inherent settings handling? (attrs might get mad check there)

Document the procedure? Only confusing thing right now is where they go and where to register them in the entrypoint I think? If something else is confusing please ask.

@jrabbit jrabbit self-assigned this Apr 27, 2019
jrabbit added a commit that referenced this issue Apr 28, 2019
@jrabbit jrabbit added this to the Pyborg 1.4 milestone May 15, 2019
@jrabbit jrabbit modified the milestones: Pyborg 1.4, 2.0 Aug 30, 2019
@jrabbit
Copy link
Owner Author

jrabbit commented Jan 26, 2020

need to wrap this up, took another go at an API change in master

@jrabbit jrabbit modified the milestones: 2.0, 2.1 Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant