Skip to content
This repository has been archived by the owner on Oct 5, 2018. It is now read-only.

support for active job #111

Merged
merged 3 commits into from
Oct 28, 2014
Merged

support for active job #111

merged 3 commits into from
Oct 28, 2014

Conversation

katafrakt
Copy link

Support for Rais 4.2 ActiveJob

@jrgifford
Copy link
Owner

Can you re-run bundle install? Travis coughed on that change.

Other than that, this looks amazing.

@ScotterC
Copy link
Collaborator

ScotterC commented Oct 3, 2014

This is awesome. Thanks @katafrakt! I can't wait to switch entirely to ActiveJob so we only have to maintain and test one implementation

@katafrakt
Copy link
Author

Here it is. I hope this time Travis will accept this (I don't know much about how it works, as we use other CI tools).

I am still working on some more elaborate tests but right now it seems to be more difficult than I thought.

@katafrakt
Copy link
Author

Oh boy... Test::Unit. This is going to be hard...

However, I understand from #72 that Test::Unit is going to be removed in favor of RSpec. Is that right?

@jrgifford
Copy link
Owner

@katafrakt Yes, that is correct. We would prefer any new stuff to be done in RSpec. Sorry for wasting your time there. :(

+ few corrections for running test within rails 4.2 env (deprecation warnings)
@katafrakt
Copy link
Author

So, here are the specs.

Rails 4.2 requires minitest 5, which is not, and will never be, compatible with Test::Unit, so I used a very dirty way to overcome this (just skipping Test::Unit with brute force). Let me know if you have another idea how to handle it.

Unfortunately, it still fails under ruby 1.9.3 and rails 4.2, which are incompatible too.

@katafrakt
Copy link
Author

OK, Travis is green now ;)

@ScotterC
Copy link
Collaborator

ScotterC commented Oct 6, 2014

This is awesome @katafrakt 👍. I wish everyone PR'ed like this.
@jrgifford Let me know if you see anything otherwise this should be merged.

@katafrakt
Copy link
Author

Sooo... Any news?

ScotterC added a commit that referenced this pull request Oct 28, 2014
@ScotterC ScotterC merged commit 6d70ab0 into jrgifford:master Oct 28, 2014
@katafrakt katafrakt deleted the active_job branch October 29, 2014 14:57
@katafrakt katafrakt restored the active_job branch November 26, 2014 14:06
@katafrakt katafrakt deleted the active_job branch October 7, 2016 07:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants