-
Notifications
You must be signed in to change notification settings - Fork 155
Conversation
Can you re-run bundle install? Travis coughed on that change. Other than that, this looks amazing. |
This is awesome. Thanks @katafrakt! I can't wait to switch entirely to ActiveJob so we only have to maintain and test one implementation |
Here it is. I hope this time Travis will accept this (I don't know much about how it works, as we use other CI tools). I am still working on some more elaborate tests but right now it seems to be more difficult than I thought. |
Oh boy... Test::Unit. This is going to be hard... However, I understand from #72 that Test::Unit is going to be removed in favor of RSpec. Is that right? |
@katafrakt Yes, that is correct. We would prefer any new stuff to be done in RSpec. Sorry for wasting your time there. :( |
+ few corrections for running test within rails 4.2 env (deprecation warnings)
So, here are the specs. Rails 4.2 requires minitest 5, which is not, and will never be, compatible with Test::Unit, so I used a very dirty way to overcome this (just skipping Test::Unit with brute force). Let me know if you have another idea how to handle it. Unfortunately, it still fails under ruby 1.9.3 and rails 4.2, which are incompatible too. |
OK, Travis is green now ;) |
This is awesome @katafrakt 👍. I wish everyone PR'ed like this. |
Sooo... Any news? |
Support for Rais 4.2 ActiveJob