This repository has been archived by the owner on Oct 5, 2018. It is now read-only.
Add support for Sidekiq 3.x #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! From your knowledge, this is backwards compatible? |
|
Yep, the >> require 'sidekiq/api'
=> true
>> Sidekiq::VERSION
=> "2.17.7"And the API that delayed_paperclip uses did not change (or otherwise the tests would break, which they do not). |
|
Great! |
|
Thanks for merging this! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like the API that delayed_paperclip uses internally doesn't change from Sidekiq 2.x to 3.x. The only thing that changed is that you now have to explicitly
require sidekiq/apiin the test files to get access toSidekiq::Queue. Changingrequire sidekiqtorequire sidekiq/apiseems to work with both Sidekiq versions. At least it works for me locally with and without an update to Sidekiq 3.x.