Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyLinac tg51 class is not fully SI compatible #110

Closed
jmartens opened this issue Nov 10, 2017 · 1 comment
Closed

PyLinac tg51 class is not fully SI compatible #110

jmartens opened this issue Nov 10, 2017 · 1 comment

Comments

@jmartens
Copy link
Contributor

Being from Europe I was a bit surprised my results were off when I entered my values. I traced it down to the p_tp class and found the documentation stating
It seems tg51 class is calculating pressure based on mmHg, where the documentation referencing the TG-51 formulas seem to use a reference pressure in kPa, judging from it's value.

    press : float
        The pressure in mmHg.

I think this should be aligned with each other.

I would prefer the SI units (and therefore pressure in (k)Pa, but I could imagine, for backwards compatibility reason, you'd prefer the documentation to be changed and use the mmHg reference value (760 mmHg) in the equation in the documentation.

@jmartens jmartens changed the title PyLinac is not fully SI compatible PyLinac tg51 class is not fully SI compatible Nov 10, 2017
@jrkerns
Copy link
Owner

jrkerns commented Nov 10, 2017

Wow, thanks for the catch! Yes, pylinac is based on mmHg. I will correct the documentation to reflect this; you are right, I will stick with mmHg for the time being. I am also working on adding warnings for any TG-51 parameter that is far out of tolerance (e.g. if kPa were used and makes the c_tp value far off from 1.0). Appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants