Text results position changed in PicketFence.publish_pdf #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As can be see in PylinacCanvas class https://github.com/jrkerns/pylinac/blob/5894520e90d45d74a1a1d184eeed0121a2238afd/pylinac/core/pdf.py#L40 by default, metadata location is (2, 25.5). That is why the superposition when we call canvas.add_text(..., location = (1.5, 25), ...) in line 982 from picketfence.py https://github.com/jrkerns/pylinac/blob/5894520e90d45d74a1a1d184eeed0121a2238afd/pylinac/picketfence.py#L981-L983 The new location to (1.5, 22) gives the posibility to show up to 7 rows
LuisOlivaresJ
changed the title
|
Looks good. thanks |
jrkerns
added a commit
that referenced
this pull request
Oct 7, 2024
RAM-4056 fix more direct density scans for the catphan 600 Approved-by: Randy Taylor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding issue #453
As can be see in line 40 from PylinacCanvas class
pylinac/pylinac/core/pdf.py
Line 40 in 5894520
by default, metadata location is (2, 25.5). That is why the superposition when we call canvas.add_text(..., location = (1.5, 25), ...) in line 982 from picketfence.py
pylinac/pylinac/picketfence.py
Lines 981 to 983 in 5894520
The new location to (1.5, 22) gives the posibility to show up to 7 metadata rows