This repository has been archived by the owner on Oct 28, 2019. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the ES API server seems to support HTTPS for all requests, this shouldn't change anything for most users, but it would greatly reduce conflicts with HTTPS Everywhere. I've tested this in Chrome for almost two weeks with HTTPS Everywhere disabled to ensure it won't cause any problems for regular users.
Although some rare problems might persist for HTTPS Everywhere users, I consider the three issues mentioned in my commit message (#1319, #1432, #1445) fixed, because this is probably the best we can get without Steam allowing HTTPS for all API requests (or us proxying them).
I'm not convinced the conflicts with HTTPS Everywhere are our fault, but if we can easily fix (or at least improve) them, we should do so.