This repository has been archived by the owner on Oct 28, 2019. It is now read-only.
Look for Twitch link in "Custom Info Box" showcase #1620
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added the ability to toggle video player fullscreen with double clicks - fixed a bug where the HD control wasn't added on the first video if Autoplay was ON
Added features sections, and made overall README more concise.
This update is being required by Mozilla, but I'm happy to oblige considering most of the project was semantically coded correctly to begin with (mostly thanks to @JoiNNN). Additionally, Valve retired their old tooltip binding code and have replaced it with something easier and more consistant. Unfortunately that means a few features are failing to load in 9.8, and this should correct that.
I guess wildcards have been supported here for a while, and make a lot more sense than listing out every single web-accessible file the extension has access to. This will allow us to add new files to the extension without making changes to the manifest. Tested in both Chrome and Firefox.
Thanks @przemo20 for pointing these out. However, their fix wasn't targeted to the dev directory and refactoring the localization file to move "hide" caused other issues. This should fix both problems.
Edited README
ADD: Video player fullscreen toggle with dblclick
UPDATE: AStats schema agnostic link (revert)
This will now properly use the parse_currency() and currency_format_info global functions so that the feature will work (in theory) with all known currency types. This should fix jshackles#1576. Thanks to @Leopard1907 and @BryanChung for pointing this out.
These should pull directly from the steam domain now, and should be SSL compliant
The images were not previously SSL compliant.
Patch until I can figure out why data isn't returning via their API or until their API gets fixed.
FIX: Chat dropdown
FIX: image link for HTTPS
…s-loader ADD: Progress bar toggle
Valve now has a support page that captures this information. They're always taking our good stuff.
No longer needed
This is still throwing a 302 redirect, will have to investigate. Will also want to reincorporate this into the page's new design.
in addition to the profile summary resolves jshackles#1619
|
Oops, wrong branch. It has been too long since I contributed. |
|
you giveup? |
|
No, I just made the PR to the wrong branch. #1621 is the correct PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Look for Twitch link in "Custom Info Box" showcase in addition to the profile summary