Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add og:image:alt support #213

Merged
merged 3 commits into from
Mar 3, 2024
Merged

feat: add og:image:alt support #213

merged 3 commits into from
Mar 3, 2024

Conversation

totto2727
Copy link
Contributor

Overview

Currently, there is no support for og:image:alt.

It seems that og:image:alt is included as part of the OGP specification, as far as I can confirm from the following

https://ogp.me/

I have added the og:image:alt parsing process and modified the tests accordingly.

Please let me know if there are any missing fixes!

@jshemas
Copy link
Owner

jshemas commented Mar 3, 2024

Thanks for the pull request! I think this is great add.

@jshemas jshemas merged commit 497cfec into jshemas:master Mar 3, 2024
3 checks passed
@jshemas
Copy link
Owner

jshemas commented Mar 3, 2024

changes are live in [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants