Bugfix/scrape all ld json objects #216
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of only the last one on the page.
…e instead of only the last one on the page.
|
Hello, thanks for the PR! I just added support for JSON LD in my last update and I think this is just a bug because I wasn't aware it was valid to have more then one JSON LD tag on a page. Can you reuse the existing |
jshemas
reviewed
Mar 27, 2024
|
Hello, I need to update this package and have addressed this problem in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some pages have more than one ld+json object. This PR will add an array of all LD JSON objects while keeping backwards compatibility with the current
ldJsonproperty.Example page with multiple LD JSON objects: https://www.homedepot.com/p/NewAir-Beverage-Froster-22-in-125-12-oz-Can-Freestanding-Cooler-Beverage-Fridge-Chills-Down-to-23-w-Party-and-Turbo-Mode-NBF125BK00/313138626