Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid ICS code #201

Closed
lukasbach opened this issue Jun 27, 2022 · 0 comments
Closed

Invalid ICS code #201

lukasbach opened this issue Jun 27, 2022 · 0 comments

Comments

@lukasbach
Copy link

The code generated by this library is not valid ICS code. This can be observed easily by pasting the output from https://datebook.dev/generators/ into e.g. https://icalendar.org/validator.html#results, where two errors are reported:

Missing DTSTAMP property [near line # 3](javascript:void(0);)
Reference: [RFC 5545 3.6.1. Event Component](http://icalendar.org/iCalendar-RFC-5545/3-6-1-event-component.html)
Missing UID property [near line # 3](javascript:void(0);)
Reference: [RFC 5545 3.6.1. Event Component](http://icalendar.org/iCalendar-RFC-5545/3-6-1-event-component.html)

The issue seems to be that those attributes are generated for the vcalendar, but are expected inside the vevent block. I'd be happy to support fixing this.
jshor added a commit that referenced this issue Nov 25, 2022
@jshor
fix(ics): corrects multi-event order #194, metadata #201
15c04b0 
This corrects the order of events added using addEvent() such that the
sequence is respected. This also addresses metadata issues for DTSTAMP,
PRODID and UID.
jshor added a commit that referenced this issue Nov 25, 2022
@jshor
fix(ics): corrects multi-event order #194, metadata #201
08f971f 
This corrects the order of events added using addEvent() such that the
sequence is respected. This also addresses metadata issues for DTSTAMP,
PRODID and UID.
@jshor jshor closed this as completed Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lukasbach @jshor