dont throw on 404s when fetching templates from iana #355
Conversation
|
We don't have tests for the update script Im realizing |
| @@ -94,7 +94,7 @@ async function addTemplateData (data, options) { | |||
| return | |||
| } | |||
|
|
|||
| let res = await got('https://www.iana.org/assignments/media-types/' + data.template) | |||
| let res = await got(`https://www.iana.org/assignments/media-types/${data.template}`, { throwHttpErrors: false }) | |||
There was a problem hiding this comment.
Actually we don't support new ES6+ syntax based on the CI: https://github.com/jshttp/mime-db/blob/master/.github/workflows/ci.yml#L13
There was a problem hiding this comment.
This script has es6 via async/await and let already, so the template string isn't a breaking introduction.
Interesting wrinkle here though, in that these scripts are part of the build tooling and we don't document the node version requirement for development/building. v11 of got has engines set to 10.19.0 https://github.com/sindresorhus/got/blob/1f6ac4597b797e6fe760a7dc11a3db8bf298aa94/package.json#L10C1-L11C1
I set up the automation PR that runs the build step on cron to use LTS node, so es6 is fine here.
|
Is this superseded by #352? or still relevant? |
|
They both will solve the 404 problem, and if we decide to switch to undici then this pr is not needed |
|
I prefer switching. Ideally at some point most of |
workaround for #345
When the update script was refactored to use
gotin 92715b3 it didn't factor in thatgotthrows on non success http status codesSo the built in 404 handling in the
addTemplateDatafunction will never run and we exit early on the unhandled promise rejection.A workaround is to set
throwHttpErrors: falsewhen fetchingBut the script needs a look over, since the assumptions about the http client's behavior are not valid anymore.
Why Now?
there were deprecated unofficial (extension) mime types which are 404ing now,
image/x-emf, image/x-wmfI don't see when they went standard as
image/emf, image/wmf, or when the extension versions started 404ing