-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Python3 + cleanups and fixes #12
Open
florisla
wants to merge
325
commits into
jsnyder:master
Choose a base branch
from
florisla:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The script took up to 0.3s for one 256 Byte block on legacy single board computers, due to invoking a write per byte, rather than writing the data block in bulk. Verified on STM32L443C6, STM32L433C6
More efficient memory writes and importable as module
So only python code is part of the folder containing __init__.py.
This facilitates automating version increments.
This is the most backwards-compatible thing we can do, and it's fairly light anyway.
Taken from the excellent https://github.com/kennethreitz/setup.py
Allowing 'python -m stm32loader'. Use the same main() method from the main script in __call__.py.
Advantage: this is available system-wide. On Windows, this also becomes an .exe file.
Make module executable
(it may work, but I don't test for it)
Now that we have a setup.cfg, also ensure that the wheel is always built as 'universal' package.
Error was spotted in #67 .
This is not optimal, but better than the stdout/stderr mix which has non-deterministic order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch covers:
#5
#9
#4
#8
Changes: