-
-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert changes to dynamic scope regarding dependence on instance #1053
Revert changes to dynamic scope regarding dependence on instance #1053
Conversation
Like I said in #1041, if either of those crefs makes sense to anyone, we can fix/clarify them and put them back in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did git diff 3cf7cb8 upstream/pull/1053
* to compare the changes (there weren't too many other commits that went in in the meantime so they're easy to mentally filter out).
I'd keep the second CREF, regarding the initial and final URI fragment, but I don't feel super strongly about it (and haven't looked too closely yet at the proposed changes that remove the requirement for two anchors). The first CREF doesn't seem applicable anymore.
* with this entry in my .git/config:
[remote "upstream"]
url = [email protected]:json-schema-org/json-schema-spec.git
fetch = +refs/heads/*:refs/remotes/upstream/*
fetch = +refs/pull/*/head:refs/remotes/upstream/pull/*
Good spot @karenetheridge |
I think there's some miscommunication here. I don't think including that cref as it is is an option. Right now it doesn't make sense. We can leave it in, but if we do we need to fix/clarify it. I've called this out multiple times now and no one has come forward with an explanation or even indicated that they know what it means. If no one understands how this cref makes sense, I think the only option is to leave it out. If we publish that and someone comes around asking what that cref means, we'd have to tell them, ¯\_(ツ)_/¯ nobody knows ¯\_(ツ)_/¯. |
Here's the cref that was removed and my comment from the previous PR.
I removed this cref because it appears to be wrong. There's no way that an $anchor can change dynamic scope resolution and even if it could, it's not clear how bookending could possibly solve that problem. If anyone knows what this means, please share and I'll put it back in. |
Mmm I'm of two minds on this, but it as we can't confidently justify it, let's leave it removed, and work out the original intent later. |
@karenetheridge Please do file an issue to review this referencing this PR =] |
I'll file the issue, I was going to suggest that approach as well. |
Since this is mostly reverting, I added jdesrosiers@321d384 to show what the actual diff is from the original spec. It's mostly typo fixes and removing a couple crefs.
The original PR was #1041