Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DKIM relaxed header canonicalization #171

Closed
breedbekkikker opened this issue Sep 2, 2015 · 3 comments
Closed

DKIM relaxed header canonicalization #171

breedbekkikker opened this issue Sep 2, 2015 · 3 comments
Labels
bug Something isn't working

Comments

@breedbekkikker
Copy link

DKIM header hash validation fails with relaxed header canonicalization of a multiline header that has FWS with WSP before CRLF.

For example, consider the following original header:

Name:[WSP]example[WSP][CRLF][WSP]value[CRLF]

The header should be after relaxed canonicalization:

name:[SP]example[SP]value[CRLF]

@jstedfast
Copy link
Owner

Can you write a unit test for me?

@jstedfast
Copy link
Owner

BTW, your example is wrong:

   o  Delete any WSP characters remaining before and after the colon
      separating the header field name from the header field value.  The
      colon separator MUST be retained.

This means that your example should end up as:

name:example[SP]value[CRLF]

jstedfast added a commit that referenced this issue Sep 2, 2015
@jstedfast jstedfast added the bug Something isn't working label Sep 2, 2015
@breedbekkikker
Copy link
Author

Thanks, I agree with your correction of the example.

I will follow up on the unit test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants