Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DKIM body hash fails for multipart messages without closing boundary #218

Closed
breedbekkikker opened this issue Jan 11, 2016 · 5 comments
Closed
Labels
bug Something isn't working

Comments

@breedbekkikker
Copy link

MimeKit always adds the closing boundary when reserializing a multipart message, even if the original message body does not contain the closing boundary. Some signed email therefore actually fails DKIM body hash validation.

@jstedfast
Copy link
Owner

Would you be willing to generate a sample message for this issue so that I can add it to my unit tests?

I was actually thinking about this potential issue the other day.

I think what I'll have to do is have the parser set a flag on the Multipart to specify whether an end boundary should be used.

@jstedfast jstedfast added the bug Something isn't working label Jan 11, 2016
@jstedfast
Copy link
Owner

FWIW, I think S/MIME and PGP/MIME will also be affected by this.

jstedfast added a commit that referenced this issue Jan 11, 2016
@breedbekkikker
Copy link
Author

Here is a sample message signed by Gmail which you might want to include in your unit tests.
email.txt

@jstedfast
Copy link
Owner

Awesome, thank you :)

@jstedfast
Copy link
Owner

This should also be fixed in MimeKit 1.2.20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants