-
-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DKIM body hash fails for multipart messages without closing boundary #218
Comments
Would you be willing to generate a sample message for this issue so that I can add it to my unit tests? I was actually thinking about this potential issue the other day. I think what I'll have to do is have the parser set a flag on the Multipart to specify whether an end boundary should be used. |
FWIW, I think S/MIME and PGP/MIME will also be affected by this. |
…nd boundary Tests the fix for issue #218
Here is a sample message signed by Gmail which you might want to include in your unit tests. |
Awesome, thank you :) |
This should also be fixed in MimeKit 1.2.20 |
MimeKit always adds the closing boundary when reserializing a multipart message, even if the original message body does not contain the closing boundary. Some signed email therefore actually fails DKIM body hash validation.
The text was updated successfully, but these errors were encountered: