Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider referencing Portable.BouncyCastle for .NET Framework #540

Closed
jjmanton opened this issue Mar 6, 2020 · 4 comments
Closed

Consider referencing Portable.BouncyCastle for .NET Framework #540

jjmanton opened this issue Mar 6, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@jjmanton
Copy link

jjmanton commented Mar 6, 2020

I am in the process of migrating a large codebase towards PackageReference, and bouncy castle has been a blocker, lacking support for the format. We are running .NET Framework 4.8, and are hoping to use Oren's fork, Portable.BouncyCastle. We also have a dependency on Mimekit, and I don't believe there is a way to tell nuget to substitute a package for a different dependency.

Would it be possible for MimeKit to reference the portable bouncy castle fork, to support those of us in transition towards Package Reference and Net Core? At least until the PR bcgit/bc-csharp#68 gets merged?

@jjmanton jjmanton changed the title Consider referencing BouncyCastle.Portable for .NET Framework Consider referencing Portable.BouncyCastle for .NET Framework Mar 6, 2020
@jstedfast
Copy link
Owner

I would not be opposed to this, I'm just worried about what sorts of problems it might have on developers already using MimeKit and BouncyCastle.

@jjmanton
Copy link
Author

jjmanton commented Mar 9, 2020

I understand that hesitantcy. As a different approach, would the maintenance overhead be too large to publish an alternate version? Either under a different NuGet package name, or possibly a pre-release version (2.5.2-Portable)?

The pre-release version would allow us to stay on the main MimeKit channel, and just upgrade once this BouncyCastle business is behind us. I am happy to pitch in if there is work to be done.

@jstedfast
Copy link
Owner

I don’t think that would be a practical solution.

@jstedfast jstedfast added the enhancement New feature or request label Mar 10, 2020
@jstedfast
Copy link
Owner

I guess we'll see how it goes. I'm not going to hold my breath that Portable.BouncyCastle will be merged into the mainline branch anytime soon. I've been waiting 3 years already :-\

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants