Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AttachDisposition text will come like inline; filename="imagea429bf… #470

Merged
merged 2 commits into from
Mar 12, 2019

Conversation

humayun-ahmed
Copy link
Contributor

@humayun-ahmed humayun-ahmed commented Mar 12, 2019

AttachDisposition text will come like inline; filename="imagea429bf.JPG"; and hence it will show error attachment.ContentDisposition.Disposition = text; as there is validation "Illegal characters in disposition value." for Disposition, please see the Content-Disposition spec https://tools.ietf.org/html/rfc6266

humayun-ahmed and others added 2 commits March 12, 2019 16:48
…PG"; and hence it will show error attachment.ContentDisposition.Disposition = text; as there is validation "Illegal characters in disposition value." for Disposition
@jstedfast jstedfast merged commit b127477 into jstedfast:master Mar 12, 2019
@jstedfast
Copy link
Owner

Thanks for the fix!

@humayun-ahmed
Copy link
Contributor Author

humayun-ahmed commented Mar 13, 2019 via email

@jstedfast
Copy link
Owner

If you have a Live account, you can download the package here: https://dev.azure.com/jestedfa/_apis/resources/Containers/785437?itemPath=MimeKit-2.1.3.5%2FMimeKit.2.1.3.5.nupkg

@humayun-ahmed
Copy link
Contributor Author

humayun-ahmed commented Mar 13, 2019 via email

@jstedfast
Copy link
Owner

I guess you'll have to build your own copy for now. I probably won't have time to make a new release until April sometime as I've got to do a lot of travel for meetings :(

@humayun-ahmed
Copy link
Contributor Author

humayun-ahmed commented Mar 14, 2019 via email

@jstedfast
Copy link
Owner

Just go to https://dev.azure.com/jestedfa/MimeKit/_build/results?buildId=29, click on Artifacts and it will download a zip file containing the nuget package.

I just tested this in a browser that was not logged in and it worked just fine so you should have no problems.

@humayun-ahmed
Copy link
Contributor Author

humayun-ahmed commented Mar 14, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants