Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Raise ValueError on crop w/ zero-overlap bbox #254

Merged
merged 1 commit into from
Aug 15, 2020

Conversation

jsvine
Copy link
Owner

@jsvine jsvine commented Aug 15, 2020

h/t @samkit-jain for catching, per example in #245

@codecov
Copy link

codecov bot commented Aug 15, 2020

Codecov Report

Merging #254 into develop will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #254   +/-   ##
========================================
  Coverage    97.36%   97.36%           
========================================
  Files           10       10           
  Lines         1138     1139    +1     
========================================
+ Hits          1108     1109    +1     
  Misses          30       30           
Impacted Files Coverage Δ
pdfplumber/page.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3786b1a...81d167e. Read the comment docs.

@jsvine jsvine merged commit d8a2f93 into develop Aug 15, 2020
@jsvine jsvine deleted the fix/crop-relative branch August 15, 2020 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants