Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Document the similarity between html-has-lang and lang #778

Merged
merged 1 commit into from
Apr 6, 2021

Conversation

denis-sokolov
Copy link
Contributor

@denis-sokolov denis-sokolov commented Mar 2, 2021

The simplest way to resolve #777.

@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #778 (0123ab1) into master (426d4c2) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 0123ab1 differs from pull request most recent head df3c7ad. Consider uploading reports for the commit df3c7ad to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #778      +/-   ##
==========================================
- Coverage   99.24%   99.24%   -0.01%     
==========================================
  Files          98       98              
  Lines        1453     1452       -1     
  Branches      477      477              
==========================================
- Hits         1442     1441       -1     
  Misses         11       11              
Impacted Files Coverage Δ
src/util/hasAccessibleChild.js 100.00% <0.00%> (ø)
src/rules/interactive-supports-focus.js 97.05% <0.00%> (ø)
__tests__/__util__/ruleOptionsMapperFactory.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 426d4c2...df3c7ad. Read the comment docs.

Copy link
Collaborator

@jessebeach jessebeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @denis-sokolov !

@ljharb ljharb merged commit df3c7ad into jsx-eslint:master Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

html-has-lang rule seems redundant with lang
3 participants