Fix jsx-indent indentation calculation with nested JSX (fixes #1117)

jsx-eslint · Mar 19, 2017 · 41bdb58 · 41bdb58
1 parent ab03af8
commit 41bdb58
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/lib/rules/jsx-indent.js b/lib/rules/jsx-indent.js
@@ -284,7 +284,7 @@ module.exports = {
       prevToken = prevToken.type === 'JSXExpressionContainer' ? prevToken.expression : prevToken;
 
       var parentElementIndent = getNodeIndent(prevToken);
-      if (prevToken.type === 'JSXElement') {
+      if (prevToken.type === 'JSXElement' && (!prevToken.parent || prevToken.parent.type !== 'LogicalExpression')) {
         parentElementIndent = getOpeningElementIndent(prevToken.openingElement);
       }
 

diff --git a/tests/lib/rules/jsx-indent.js b/tests/lib/rules/jsx-indent.js
@@ -459,6 +459,22 @@ ruleTester.run('jsx-indent', rule, {
     ].join('\n'),
     options: [2],
     parserOptions: parserOptions
+  }, {
+    code: [
+      'function foo() {',
+      '  return (',
+      '    <div>',
+      '      {bar &&',
+      '        <Div>',
+      '          <span />',
+      '        </Div>',
+      '      }',
+      '    </div>',
+      '  );',
+      '}'
+    ].join('\n'),
+    options: [2],
+    parserOptions: parserOptions
   }],
 
   invalid: [{