Fix no-danger-with-children crash with spread on global variables (fixes

#921)
jsx-eslint · Nov 13, 2016 · fe5594b · fe5594b
1 parent 1df6118
commit fe5594b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/lib/rules/no-danger-with-children.js b/lib/rules/no-danger-with-children.js
@@ -56,7 +56,7 @@ module.exports = {
       return attributes.find(function (attribute) {
         if (attribute.type === 'JSXSpreadAttribute') {
           var variable = findSpreadVariable(attribute.argument.name);
-          if (variable && variable.defs[0].node.init) {
+          if (variable && variable.defs.length && variable.defs[0].node.init) {
             return findObjectProp(variable.defs[0].node.init, propName);
           }
         }

diff --git a/tests/lib/rules/no-danger-with-children.js b/tests/lib/rules/no-danger-with-children.js
@@ -30,6 +30,13 @@ ruleTester.run('no-danger-with-children', rule, {
       code: '<div>Children</div>',
       parserOptions: parserOptions
     },
+    {
+      code: '<div {...props} />',
+      parserOptions: parserOptions,
+      globals: {
+        props: true
+      }
+    },
     {
       code: '<div dangerouslySetInnerHTML={{ __html: "HTML" }} />',
       parserOptions: parserOptions