Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsx-no-leaked-render silent error reporting for empty string react >=18 #3487

Closed
wants to merge 0 commits into from
Closed

jsx-no-leaked-render silent error reporting for empty string react >=18 #3487

wants to merge 0 commits into from

Conversation

himanshu007-creator
Copy link
Contributor

resolves #3479

@ljharb
Copy link
Member

ljharb commented Nov 16, 2022

Duplicate of #3488; let's keep both open, though, to keep them in sync.

@ljharb ljharb reopened this Nov 16, 2022
@ljharb ljharb force-pushed the master branch 4 times, most recently from 069314a to 181c68f Compare November 18, 2022 17:19
@himanshu007-creator
Copy link
Contributor Author

We can close this one @ljharb right?

@ljharb ljharb closed this Nov 21, 2022
@ljharb ljharb force-pushed the himanshu-jsx-on-leaked-render branch from 3dd1215 to c02d4e3 Compare November 21, 2022 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jsx-no-leaked-render: Don't report errors on empty strings if React >= v18
2 participants
@himanshu007-creator @ljharb