Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] sort-prop-types: single line type ending without semicolon #3784

Merged
merged 1 commit into from
Jul 19, 2024
Merged

[Fix] sort-prop-types: single line type ending without semicolon #3784

merged 1 commit into from
Jul 19, 2024

Conversation

akulsr0
Copy link
Contributor

@akulsr0 akulsr0 commented Jul 18, 2024 •
edited
Loading

Partially fixes #3783

ljharb
ljharb reviewed Jul 18, 2024
View reviewed changes
lib/util/propTypesSort.js Outdated Show resolved Hide resolved
tests/lib/rules/sort-prop-types.js Outdated Show resolved Hide resolved
@akulsr0
Copy link
Contributor Author

akulsr0 commented Jul 18, 2024

@ljharb Failing test looks like a fluke, can we rerun failing test once?

@akulsr0 akulsr0 marked this pull request as ready for review July 18, 2024 06:06
@ljharb
Copy link
Member

ljharb commented Jul 18, 2024

The failures are due to nodejs/node#53902. Once that's resolved, I'll rerun them.

@ljharb ljharb changed the title [Fix]sort-prop-types: single line type ending without semicolon [Fix] sort-prop-types: single line type ending without semicolon Jul 19, 2024
@ljharb ljharb force-pushed the akul/issue-3783 branch from 7c80ba8 to a08cb93 Compare July 19, 2024 21:33
@codecov Codecov
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.62%. Comparing base (2fdf0b4) to head (a08cb93).
Report is 5 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3784      +/-   ##
==========================================
- Coverage   97.76%   97.62%   -0.15%     
==========================================
  Files         135      132       -3     
  Lines        9680     9697      +17     
  Branches     3515     3522       +7     
==========================================
+ Hits         9464     9467       +3     
- Misses        216      230      +14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ljharb ljharb merged commit a08cb93 into jsx-eslint:master Jul 19, 2024
344 of 345 checks passed
@tylerlaprade tylerlaprade mentioned this pull request Jul 22, 2024
Closed
2 tasks
@alhugot-azpn alhugot-azpn mentioned this pull request Aug 10, 2024
Merged
@zdr4k zdr4k mentioned this pull request Aug 10, 2024
Open
@Balantion2020 Balantion2020 mentioned this pull request Aug 10, 2024
Open
@Tanver-Hasan Tanver-Hasan mentioned this pull request Aug 10, 2024
Open
This was referenced Aug 10, 2024
Open
Open
Open
This was referenced Aug 10, 2024
Open
Open
@patooworld patooworld mentioned this pull request Aug 10, 2024
Open
This was referenced Aug 10, 2024
Open
Open
@Exkaleburx Exkaleburx mentioned this pull request Aug 10, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Aug 10, 2024
Open
@Luis-Kristen Luis-Kristen mentioned this pull request Aug 11, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Aug 11, 2024
Open
@richyhoopd richyhoopd mentioned this pull request Aug 11, 2024
Open
@alhugot-azpn alhugot-azpn mentioned this pull request Aug 12, 2024
Closed
@ASISBusiness ASISBusiness mentioned this pull request Aug 16, 2024
Closed
@Exkaleburx Exkaleburx mentioned this pull request Oct 4, 2024
Open
@CASABECI CASABECI mentioned this pull request Oct 6, 2024
Open
@scatools-demo scatools-demo mentioned this pull request Oct 6, 2024
Open
@Sarrac3873 Sarrac3873 mentioned this pull request Oct 16, 2024
Open
@zdr4k zdr4k mentioned this pull request Oct 20, 2024
Open
This was referenced Oct 22, 2024
Open
Open
Open
@Loonz206 Loonz206 mentioned this pull request Oct 23, 2024
Open
This was referenced Oct 23, 2024
Open
Open
Open
@ManuelDevWeb ManuelDevWeb mentioned this pull request Oct 25, 2024
Open
@Exkaleburx Exkaleburx mentioned this pull request Oct 26, 2024
Open
@richyhoopd richyhoopd mentioned this pull request Oct 26, 2024
Open
@scatools-demo scatools-demo mentioned this pull request Oct 26, 2024
Open
@ManuelDevWeb ManuelDevWeb mentioned this pull request Oct 26, 2024
Open
@Vishesh7797 Vishesh7797 mentioned this pull request Oct 27, 2024
Open
@Exkaleburx Exkaleburx mentioned this pull request Oct 27, 2024
Open
@zdr4k zdr4k mentioned this pull request Oct 27, 2024
Open
@DadonStyle DadonStyle mentioned this pull request Oct 27, 2024
Open
@ManuelDevWeb ManuelDevWeb mentioned this pull request Oct 28, 2024
Open
@Tanver-Hasan Tanver-Hasan mentioned this pull request Oct 31, 2024
Open
@scatools-demo scatools-demo mentioned this pull request Nov 2, 2024
Open
@Balantion2020 Balantion2020 mentioned this pull request Nov 2, 2024
Open
@DadonStyle DadonStyle mentioned this pull request Nov 3, 2024
Open
@Tanver-Hasan Tanver-Hasan mentioned this pull request Nov 7, 2024
Open
@Luis-Kristen Luis-Kristen mentioned this pull request Nov 7, 2024
Open
@ManuelDevWeb ManuelDevWeb mentioned this pull request Nov 11, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Nov 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: sort-prop-types's autofix doesn't move the semicolon, producing broken code, on single-line Props types
2 participants
@akulsr0 @ljharb