Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valid self reference jsx element. #905

Merged
merged 3 commits into from
Oct 18, 2016
Merged

Valid self reference jsx element. #905

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
83bd290
Valid self reference jsx element.
xeodou Oct 12, 2016
daf7726
Add class based component test.
xeodou Oct 12, 2016
9002a7e
Add state less component test.
xeodou Oct 12, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/rules/forbid-component-props.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ module.exports = {
return {
JSXAttribute: function(node) {
var tag = node.parent.name.name;
if (tag[0] !== tag[0].toUpperCase()) {
if (tag && tag[0] !== tag[0].toUpperCase()) {
// This is a DOM node, not a Component, so exit.
return;
}
Expand Down
11 changes: 11 additions & 0 deletions tests/lib/rules/forbid-component-props.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,17 @@ ruleTester.run('forbid-component-props', rule, {
].join('\n'),
options: [{forbid: ['style', 'foo']}],
parserOptions: parserOptions
}, {
code: [
'var First = React.createClass({',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you also add examples with an SFC, and with a class-based component?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, SFC is short for self-closing component right ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no - it's for "stateless functional component" - ie, a function that takes props and returns JSX

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, Thanks. I know 'stateless functional component' , just have no idea what does SFC meaning. Thanks for point out

' propTypes: externalPropTypes,',
' render: function() {',
' return <this.Foo className="bar" />;',
' }',
'});'
].join('\n'),
options: [{forbid: ['style', 'foo']}],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm - why would "foo" lowercase catch "Foo", which is a distinct property in JS?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me check the test.

Copy link
Contributor Author

@xeodou xeodou Oct 12, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think i just forget remove the line options: [{forbid: ['style', 'foo']}], it shouldn't relate to forbid option.

parserOptions: parserOptions
}],

invalid: [{
Expand Down