Fix jsx-indent bug on multiline ternary #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This (unfortunately) won't deal with this, still requiring that the cond
?
<div/>
:
<span/>Though not supporting even the case where you use parens is certainly the bigger evil. |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt at fixing #945.
I'm no master at ESLint or it's parser, but adding some new tests and looking at the AST and figuring out what it would take to make the new test pass while not breaking the tests from d88ee37 gave the following solution.
I also ran this version of the module against my large react project and all errors that occurred with
6.6.0was then gone.