-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minor cleanups, install man page, git ignore debris, LaTeX manual #2
Open
barak
wants to merge
41
commits into
juanjosegarciaripoll:master
Choose a base branch
from
barak:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wget --output-document=ChangeLog http://www.netlib.org/f2c/changes
barak
changed the title
minor cleanups, install man page, git ignore debris
minor cleanups, install man page, git ignore debris, LaTeX manual
May 27, 2016
Downloaded original manual wget http://www.netlib.org/f2c/f2c.pdf and engaged various tools culminating in some LaTeX-fu. Did not bother with headers/footers or matching font sizes.
Better match paper and font size and spacing. Include f2c(1) man page in Appendix B. Convert references to bibtex. Live hyperlinks to sections and references. Git ignore documentation build debris. Indent Fortran code in the report, including snippets missed in the original. Note PDF-to-LaTeX conversion on title page. Fix one f2c vs F2c capitalization typo.
Use standard autoconf mechanism to enable compiler warnings when possible.
Check for function attribute "weak" and, if available, make MAIN__ a weak symbol in libf2c, in order to allow C programs to link -lf2c without any problems. Also make main a weak symbol, just in case, because we really don't want to override a C program's main routine. Thanks to Christian Seiler <[email protected]> for the patch. See the Debian bug report, https://bugs.debian.org/826253
open.c: In function ‘fk_open’: open.c:222:28: warning: ‘%ld’ directive writing between 1 and 11 bytes into a region of size 5 [-Wformat-overflow=] (void) sprintf(nbuf,"fort.%ld",(long)n); ^~~ open.c:222:22: note: directive argument in the range [-2147483648, 2147483647] (void) sprintf(nbuf,"fort.%ld",(long)n); ^~~~~~~~~~ open.c:222:2: note: ‘sprintf’ output between 7 and 17 bytes into a destination of size 10 (void) sprintf(nbuf,"fort.%ld",(long)n); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
"if (a=b)" -> "if ((a=b))" "a && b || c" -> "(a && b) || c" "a >> b - c" -> "a >> (b - c)" "for (,a=b,)" -> "for (,(a=b),)"
lib/main.c:92:3: error: implicit declaration of function 'MAIN_'; did you mean 'MAIN__'? [-Wimplicit-function-declaration] lib/main.c:93:3: error: implicit declaration of function 'libf2c_exit'; did you mean 'libf2c_init'? [-Wimplicit-function-declaration]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor build system tweaks, e.g., install documentation including man page, squelch some autotools warnings, add automake -Wall option, remove all generated files.
Add .so library version number, set to match Debian's current .so number.
Update f2c(1) markup and remove pre-formatted f2c(1).
Update .gitignore.
Cherry pick patch from catull:
The function rmdir() is used in src/sysdep.c before it is included with the header unistd.h.
Thus, the header must be included beforehand.
Snag Changelog from netlib.org.
Add manual (distributed as f2c.pdf) re-marked-up in LaTeX.
Make
main
andMAIN__
weak pointers, if possible, to allowcc -lf2c ...
from C/C++. See ff9a101 and https://bugs.debian.org/826253.