Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

function create using write concern #26

Merged
merged 4 commits into from
Apr 22, 2014
Merged

Conversation

victor-carv
Copy link

discussion of the problem here: 1602/compound#619

I took a look at what has changed in mongodb version 0.9 to the current and I found the problem.
In the newest version of the mongodb module, it treats the concept of writing concern, which I found here: http://mongodb.github.io/node-mongodb-native/api-generated/collection.html#insert

In this pull request I treated the setting to write concern

options.w = options.w || 1;

this.collection(model).insert(data, options, function (err, m) {
if (err || options.w < 1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. missing {
  2. identation

@1602
Copy link
Contributor

1602 commented Apr 21, 2014

It also would be great to explain meaning of this flag in readme.

@victor-carv
Copy link
Author

ok, it's done

1602 added a commit that referenced this pull request Apr 22, 2014
function create using write concern
@1602 1602 merged commit 47f3433 into jugglingdb:master Apr 22, 2014
@victor-carv
Copy link
Author

Hi,
the version 0.0.4-4 of mongodb-adapter will be published soon?
thanks

@1602
Copy link
Contributor

1602 commented Jun 12, 2014

Published. Sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants