Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Https Section to Azure Setup Guide #118

Merged
merged 3 commits into from
Jul 13, 2022

Conversation

sydseter
Copy link
Contributor

@sydseter sydseter commented Jun 1, 2022

I have added a guide for how to setup ssl for multi-juicer using a nginx kubernetes controller.
I saw that there already was an option for setting up ssl by applying the proper configuration to values.yaml during the installation of multi-juicer, but I found it quite hard to setup this for someone like me with limited kubernetes knowledge.
There are too many options that you need to take into account and I think it would be better to just have a very simple and straightforward guide on how to do this so that the user doesn't get lost.

Copy link
Member

@J12934 J12934 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋
Sorry for taking so long to find time to look at this PR.

The docs look great and should be easy to follow 👍

@J12934 J12934 added the documentation Improvements or additions to documentation label Jul 13, 2022
@J12934 J12934 changed the title Feature/azure ssl Add Https Section to Azure Setup Guide Jul 13, 2022
@J12934 J12934 merged commit 9ec7658 into juice-shop:main Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants