Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agents-api): fix fn calling and local deployment #378

Merged
merged 2 commits into from
May 31, 2024

Conversation

alt-glitch
Copy link
Contributor

@alt-glitch alt-glitch commented May 31, 2024

  • added json.dumps() when role was function_call
  • added port for cozo

🚀 This description was created by Ellipsis for commit 036a1c3

Summary:

This PR fixes function call serialization in the agents API and adds a port configuration for local deployment in Docker.

Key points:

  • added json.dumps() when role was function_call
  • added port for cozo

Generated with ❤️ by ellipsis.dev

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to f52f814 in 1 minute and 26 seconds

More details
  • Looked at 39 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. deploy/docker-compose.yml:17
  • Draft comment:
    The port mapping "9070:9070" for the memory-store service is correctly added to expose the service on the specified port. This change aligns with the environment configuration within the service.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The addition of the port mapping for the memory-store service in the docker-compose.yml file is intended to expose the service on port 9070. This change is consistent with the environment variable COZO_PORT=9070 set in the same service, which suggests that the service is configured to listen on this port. The mapping "9070:9070" ensures that the port 9070 on the host is mapped to the port 9070 on the container, allowing external access to the service at this port.

Workflow ID: wflow_KnUv4i5i9SMBngwX


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@whiterabbit1983 whiterabbit1983 merged commit bbb4544 into dev May 31, 2024
9 checks passed
@whiterabbit1983 whiterabbit1983 deleted the f/misc-fixes branch May 31, 2024 11:43
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 036a1c3 in 1 minute and 53 seconds

More details
  • Looked at 14 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. agents-api/agents_api/routers/sessions/session.py:193
  • Draft comment:
    Ensure that model_dump_json() correctly serializes the function call data into JSON format. If it returns a Python dictionary instead of a JSON string, you might still need to use json.dumps() to properly serialize it.
  • Reason this comment was not posted:
    Confidence of 0% on close inspection, compared to threshold of 50%.

Workflow ID: wflow_IXWv7Bq72BjhPZou


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants