NPC orientation fixes #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derklaro
approved these changes
Aug 3, 2023
|
I just cleaned the code in this PR up a bit - it looks good to me just by looking at the code, let me know about your test results and I will merge changes :) |
|
Noticed that on minestom the npc won't appear until the player moves. Also fixed that in the last commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit removes unnecessary check if the player orientation changed (bukkit)
Second commit should fix NPC orientation when a player moves on bukkit and minestom
Third commit should fix the same NPC orientation bug from #108 on minestom
Haven't been able to test any of the commits yet and probably won't be able to do so until late afternoon/evening.
Just wanted to make this PR to remove redundant work if any of you wanted to start working.