Skip to content

Commit

Permalink
fix(docs): fix webhook installation url (argoproj#1053)
Browse files Browse the repository at this point in the history
Signed-off-by: Derek Wang <[email protected]>
  • Loading branch information
whynowy authored Feb 9, 2021
1 parent 3a57660 commit e43c785
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
8 changes: 4 additions & 4 deletions docs/validating-admission-webhook.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,16 +8,16 @@

Starting from v1.3, a
[Validating Admission Webhook](https://kubernetes.io/docs/reference/access-authn-authz/admission-controllers/#validatingadmissionwebhook)
is introduced to the project. To install Argo Events with the validating
webhook, use following command (update the version):
is introduced to the project. To install the validating webhook, use following
command (change the version):

```shell
kubectl apply -n argo-events -f https://raw.githubusercontent.com/argoproj/argo-events/{version}/manifests/install-with-extension.yaml
kubectl apply -n argo-events -f https://raw.githubusercontent.com/argoproj/argo-events/{version}/manifests/install-validating-webhook.yaml
```

## Benefits

Using the validation webhook has following benefits:
Using the validating webhook has following benefits:

1. It notifies the error at the time applying the faulty spec, so that you don't
need to check the CRD object `status` field to see if there's any condition
Expand Down
1 change: 1 addition & 0 deletions mkdocs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ nav:
- 'webhook-health-check.md'
- 'trigger-conditions.md'
- 'service-accounts.md'
- 'validating-admission-webhook.md'
- 'developer_guide.md'
- 'FAQ.md'
- Releases ⧉: https://github.com/argoproj/argo-events/releases
Expand Down

0 comments on commit e43c785

Please sign in to comment.