Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix numerical issue in primal infeasibility certificates #129

Merged
merged 2 commits into from
Nov 29, 2021
Merged

Conversation

odow
Copy link
Member

@odow odow commented Nov 29, 2021

Needed to pass the upcoming tests in MOI 0.10.6:
jump-dev/SolverTests#17

Passing on my local machine:

 1  -3.000e+00  -4.309e+00  +2e+00  6e-02  5e-02  3e-01  5e-01  0.8642  3e-03   1  1  1 |  0  0
 2  -3.000e+00  +8.743e+00  +3e-01  3e+00  4e-01  4e+01  9e-02  0.9400  1e-01   1  1  1 |  0  0
 3  -3.000e+00  +3.614e+03  +4e-03  3e+00  4e-01  4e+03  1e-03  0.9886  1e-04   1  1  1 |  0  0
 4  -2.999e+00  +2.685e+05  +4e-05  2e+00  3e-01  3e+05  1e-05  0.9890  1e-04   1  1  1 |  0  0
 5  -2.999e+00  +2.067e+07  +5e-07  2e+00  3e-01  2e+07  1e-07  0.9890  1e-04   2  0  0 |  0  0

PRIMAL INFEASIBLE (within feastol=4.8e-09).
Runtime: 0.000076 seconds.

Test Summary:             | Pass  Total
Test the direct interface |    3      3
WARNING: replacing module TestECOS.
Test Summary:    | Pass  Total
MathOptInterface | 2501   2501
Test.DefaultTestSet("MathOptInterface", Any[Test.DefaultTestSet("test_RawOptimizerAttribute", Any[], 2, false, false), Test.DefaultTestSet("test_iteration_limit", Any[], 2, false, false), Test.DefaultTestSet("test_runtests", Any[Test.DefaultTestSet("test_add_constrained_variables_vector", Any[], 6, false, false), Test.DefaultTestSet("test_attribute_NumberThreads", Any[], 0, false, false), Test.DefaultTestSet("test_attribute_RawStatusString", Any[], 1, false, false), Test.DefaultTestSet("test_attribute_Silent", Any[], 4, false, false), Test.DefaultTestSet("test_attribute_SolveTimeSec", Any[], 2, false, false), Test.DefaultTestSet("test_attribute_SolverName", Any[], 1, false, false), Test.DefaultTestSet("test_attribute_SolverVersion", Any[], 1, false, false), Test.DefaultTestSet("test_attribute_TimeLimitSec", Any[], 0, false, false), Test.DefaultTestSet("test_attribute_after_empty", Any[], 4, false, false), Test.DefaultTestSet("test_basic_ScalarAffineFunction_EqualTo", Any[], 23, false, false)  …  Test.DefaultTestSet("test_variable_delete_Nonnegatives_row", Any[], 12, false, false), Test.DefaultTestSet("test_variable_delete_SecondOrderCone", Any[], 10, false, false), Test.DefaultTestSet("test_variable_delete_variables", Any[], 9, false, false), Test.DefaultTestSet("test_variable_get_VariableIndex", Any[], 2, false, false), Test.DefaultTestSet("test_variable_solve_Integer_with_lower_bound", Any[], 0, false, false), Test.DefaultTestSet("test_variable_solve_Integer_with_upper_bound", Any[], 0, false, false), Test.DefaultTestSet("test_variable_solve_ZeroOne_with_0_upper_bound", Any[], 0, false, false), Test.DefaultTestSet("test_variable_solve_ZeroOne_with_upper_bound", Any[], 0, false, false), Test.DefaultTestSet("test_variable_solve_with_lowerbound", Any[], 10, false, false), Test.DefaultTestSet("test_variable_solve_with_upperbound", Any[], 12, false, false)], 0, false, false)], 0, false, false)

(ECOS) pkg> st
     Project ECOS v0.14.0
      Status `~/.julia/dev/ECOS/Project.toml`
  [fa961155] CEnum v0.4.1
  [b8f27783] MathOptInterface v0.10.5 `https://github.com/jump-dev/MathOptInterface.jl.git#master`
  [c2c64177] ECOS_jll v2.0.8+1

@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #129 (69073d6) into master (4b6487f) will increase coverage by 0.46%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #129      +/-   ##
==========================================
+ Coverage   76.11%   76.58%   +0.46%     
==========================================
  Files           3        3              
  Lines         201      205       +4     
==========================================
+ Hits          153      157       +4     
  Misses         48       48              
Impacted Files Coverage Δ
src/MOI_wrapper/MOI_wrapper.jl 74.71% <100.00%> (+0.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b6487f...69073d6. Read the comment docs.

src/MOI_wrapper/MOI_wrapper.jl Outdated Show resolved Hide resolved
@odow odow merged commit 607e5f2 into master Nov 29, 2021
@odow odow deleted the od/updates branch November 29, 2021 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants